transformations: Convert memref to ptrdialect
#3383
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3383 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 451 452 +1
Lines 56868 56951 +83
Branches 5459 5467 +8
=======================================
+ Hits 51256 51331 +75
- Misses 4167 4173 +6
- Partials 1445 1447 +2 ☔ View full report in Codecov by Sentry. |
| ) | ||
| ] | ||
|
|
||
| if len(list(indices)) == 0: |
There was a problem hiding this comment.
| if len(list(indices)) == 0: | |
| if not indices: |
There was a problem hiding this comment.
It looks like the indices passed below are actually a Collection, so this should be possible, and would avoid an extra list construction
| def apply(self, ctx: MLContext, op: builtin.ModuleOp) -> None: | ||
| the_one_pass = PatternRewriteWalker( | ||
| GreedyRewritePatternApplier([ConvertStoreOp(), ConvertLoadOp()]), | ||
| apply_recursively=False, |
There was a problem hiding this comment.
Similarly for the other options below
| from xdsl.utils.exceptions import DiagnosticException | ||
|
|
||
|
|
||
| # I think we also need to pass the adress width. |
There was a problem hiding this comment.
yeah, forgot to delete this comment from a previous version
| case builtin.StridedLayoutAttr(): | ||
| strides = memref_type.layout.get_strides() | ||
| case _: | ||
| raise DiagnosticException(f"Unsupported layout type {memref_type.layout}") |
There was a problem hiding this comment.
Oh I forgot about this, could you please add a small PR with a test that catches this diagnostic exception?
Introducing lowering of some memref operations to a ptr dialect. This will be used to translate riscv compilation to ptr dialect in the future (this is the second pr in the series).
Introducing lowering of some memref operations to a ptr dialect. This will be used to translate riscv compilation to ptr dialect in the future (this is the second pr in the series).