Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transformations: check invalid cases in memref -> ptr conversion #3392

Merged
merged 1 commit into from
Nov 4, 2024
Merged

transformations: check invalid cases in memref -> ptr conversion #3392

merged 1 commit into from
Nov 4, 2024

Conversation

mamanain
Copy link
Collaborator

@mamanain mamanain commented Nov 4, 2024

Add missing test cases.

@mamanain mamanain added the transformations Changes or adds a transformatio label Nov 4, 2024
@mamanain mamanain self-assigned this Nov 4, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (87e1a46) to head (c14a51d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3392   +/-   ##
=======================================
  Coverage   90.13%   90.14%           
=======================================
  Files         452      452           
  Lines       57157    57157           
  Branches     5498     5498           
=======================================
+ Hits        51519    51524    +5     
+ Misses       4180     4176    -4     
+ Partials     1458     1457    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mamanain mamanain changed the title transforms: check invalid cases in memref -> ptr conversion transformations: check invalid cases in memref -> ptr conversion Nov 4, 2024
@superlopuh superlopuh self-requested a review November 4, 2024 14:03
superlopuh
superlopuh approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@superlopuh superlopuh merged commit d0797bd into xdslproject:main Nov 4, 2024
15 checks passed
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
@mamanain @EdmundGoodman
transformations: check invalid cases in memref -> ptr conversion (x…
e96b5a5 
…dslproject#3392)

Add missing test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superlopuh superlopuh superlopuh approved these changes

Assignees

@mamanain mamanain

Labels
transformations Changes or adds a transformatio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamanain @superlopuh