Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (llvm) avoid double whitespace after exact #3415

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

tobiasgrosser
Copy link
Contributor

The pretty printer of the exact keyword accidentally printed two whitespaces in a row, which led to non-canical code being emitted. This change ensures we only print a single whitespace after the exact keyword.

The pretty printer of the `exact` keyword accidentally printed two
whitespaces in a row, which led to non-canical code being emitted.
This change ensures we only print a single whitespace after the
`exact` keyword.
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (e150009) to head (b4fb20a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3415   +/-   ##
=======================================
  Coverage   90.16%   90.16%           
=======================================
  Files         455      455           
  Lines       57467    57467           
  Branches     5532     5532           
=======================================
  Hits        51815    51815           
  Misses       4195     4195           
  Partials     1457     1457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasgrosser tobiasgrosser merged commit de1bee5 into main Nov 9, 2024
15 checks passed
@tobiasgrosser tobiasgrosser deleted the tobias/llvm_exact_whitespace branch November 9, 2024 01:35
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
)

The pretty printer of the `exact` keyword accidentally printed two
whitespaces in a row, which led to non-canical code being emitted. This
change ensures we only print a single whitespace after the `exact`
keyword.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant