Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (llvm) added overflow flags to trunc #3422

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

lfrenot
Copy link
Collaborator

@lfrenot lfrenot commented Nov 11, 2024

No description provided.

@lfrenot lfrenot added the dialects Changes on the dialects label Nov 11, 2024
@lfrenot lfrenot self-assigned this Nov 11, 2024
@lfrenot lfrenot marked this pull request as draft November 11, 2024 15:28
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (e03689e) to head (542f3e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
- Coverage   90.16%   90.16%   -0.01%     
==========================================
  Files         455      455              
  Lines       57475    57501      +26     
  Branches     5532     5534       +2     
==========================================
+ Hits        51822    51845      +23     
- Misses       4196     4197       +1     
- Partials     1457     1459       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lfrenot lfrenot marked this pull request as ready for review November 11, 2024 15:46
@tobiasgrosser
Copy link
Contributor

There are conflicts to be resolved, also do you want to use the assembly printer?

@lfrenot lfrenot force-pushed the leon/llvm-trunc-overflow branch from dfb9199 to 542f3e7 Compare November 11, 2024 16:34
@lfrenot
Copy link
Collaborator Author

lfrenot commented Nov 11, 2024

This should fix the conflicts
Also, I don't think the assembly printer is usable here because of the overflow flags.

@tobiasgrosser tobiasgrosser merged commit 5df40db into main Nov 11, 2024
15 checks passed
@tobiasgrosser tobiasgrosser deleted the leon/llvm-trunc-overflow branch November 11, 2024 17:25
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants