Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewriting: add attr_constr_rewrite_pattern #3439

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

superlopuh
Copy link
Member

Step 1 of removing ParamDef is to provide a constraint-based alternative to the type-based attr_type_rewrite_pattern.

@superlopuh superlopuh added the rewriting changes on xDSL rewrite engine label Nov 13, 2024
@superlopuh superlopuh self-assigned this Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (26b8eeb) to head (691c1a6).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3439   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files         458      458           
  Lines       57700    57676   -24     
  Branches     5544     5541    -3     
=======================================
- Hits        52086    52065   -21     
+ Misses       4169     4167    -2     
+ Partials     1445     1444    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh merged commit 7b829a1 into main Nov 13, 2024
15 checks passed
@superlopuh superlopuh deleted the sasha/pyrdl/attr-constr-rewrite-pattern branch November 13, 2024 14:08
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
Step 1 of removing ParamDef is to provide a constraint-based alternative
to the type-based `attr_type_rewrite_pattern`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rewriting changes on xDSL rewrite engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants