-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interpreter: (pdl) add test for result matching #3465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you meant but it may be helpful to add singe-sentence comments to explain what each assertion is doing. They look all the same and took me a few mins to figure out...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3465 +/- ##
==========================================
+ Coverage 90.22% 90.24% +0.02%
==========================================
Files 462 462
Lines 57734 57761 +27
Branches 5565 5565
==========================================
+ Hits 52090 52127 +37
+ Misses 4198 4193 -5
+ Partials 1446 1441 -5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Another PR adding tests to existing PDL infrastructure. Note stacked PR
Another PR adding tests to existing PDL infrastructure.
Note stacked PR