Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpreter: (pdl) add test for result matching #3465

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

superlopuh
Copy link
Member

@superlopuh superlopuh commented Nov 18, 2024

Another PR adding tests to existing PDL infrastructure.

Note stacked PR

@superlopuh superlopuh added the interpreter xDSL Interpreter label Nov 18, 2024
@superlopuh superlopuh self-assigned this Nov 18, 2024
Copy link
Collaborator

@jianyicheng jianyicheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you meant but it may be helpful to add singe-sentence comments to explain what each assertion is doing. They look all the same and took me a few mins to figure out...

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (029c9f5) to head (c9bd086).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3465      +/-   ##
==========================================
+ Coverage   90.22%   90.24%   +0.02%     
==========================================
  Files         462      462              
  Lines       57734    57761      +27     
  Branches     5565     5565              
==========================================
+ Hits        52090    52127      +37     
+ Misses       4198     4193       -5     
+ Partials     1446     1441       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Base automatically changed from sasha/pdl/unit-tests to main November 18, 2024 20:59
@superlopuh superlopuh merged commit 3074ded into main Nov 18, 2024
15 checks passed
@superlopuh superlopuh deleted the sasha/pdl/unit-test-result branch November 18, 2024 21:19
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
Another PR adding tests to existing PDL infrastructure.

Note stacked PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter xDSL Interpreter
Projects
Development

Successfully merging this pull request may close these issues.

3 participants