dialects: (bufferization) Simplify tensor/memref constraint #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3475 +/- ##
==========================================
+ Coverage 90.27% 90.28% +0.01%
==========================================
Files 462 462
Lines 57845 57860 +15
Branches 5565 5563 -2
==========================================
+ Hits 52218 52240 +22
+ Misses 4190 4187 -3
+ Partials 1437 1433 -4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
superlopuh
reviewed
Nov 19, 2024
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
superlopuh
reviewed
Nov 19, 2024
xdsl/dialects/bufferization.py
Outdated
| if isa(attr, UnrankedTensorType[Attribute]): | ||
| memref_type = UnrankedMemrefType.from_type(attr.element_type) | ||
| return self.memref_constraint.verify(memref_type, constraint_context) | ||
| raise VerifyException(f"Expected TensorType or UnrankedTensorType, got {attr}") |
There was a problem hiding this comment.
worth adding a test for this?
There was a problem hiding this comment.
I think it's probably OK to merge without this but if it's quick and easy it would catch this sort of thing in the future, hopefully
There was a problem hiding this comment.
Added an array of tests
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
…ect#3475) Removes the `TensorMemrefInferenceConstraint` in favour of a simpler `TensorFromMemrefConstraint`. --------- Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
TensorMemrefInferenceConstraintin favour of a simplerTensorFromMemrefConstraint.