Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects (arm): add assembly printing #3485

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Conversation

emmau678
Copy link
Contributor

Add assembly printing for ARM instructions
Note: stacked PR

@emmau678 emmau678 added the dialects Changes on the dialects label Nov 20, 2024
@emmau678 emmau678 self-assigned this Nov 20, 2024
pyproject.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (ed6bcf9) to head (42d6789).
Report is 1 commits behind head on emma/arm-mov-op.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           emma/arm-mov-op    #3485      +/-   ##
===================================================
- Coverage            90.28%   90.26%   -0.03%     
===================================================
  Files                  462      463       +1     
  Lines                57950    57882      -68     
  Branches              5567     5570       +3     
===================================================
- Hits                 52323    52248      -75     
- Misses                4192     4195       +3     
- Partials              1435     1439       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

emmau678 and others added 2 commits November 20, 2024 09:51


// CHECK: %x1 = arm.get_register : !arm.reg<x1>
%x1 = arm.get_register : !arm.reg<x1>

// CHECK: %ds_mov = arm.ds.mov %x1 : (!arm.reg<x1>) -> !arm.reg<x2>
// CHECK-ASM: mov x2, x1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to get a test that includes a comment

xdsl/dialects/arm/ops.py Show resolved Hide resolved
@emmau678 emmau678 marked this pull request as ready for review November 20, 2024 14:50
@emmau678 emmau678 merged commit 05d6c38 into emma/arm-mov-op Nov 25, 2024
15 checks passed
@emmau678 emmau678 deleted the emma/add-asm-printing branch November 25, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants