core: simplify TypedAttribute #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
added
minor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3487 +/- ##
=======================================
Coverage 90.29% 90.29%
=======================================
Files 462 462
Lines 57937 57937
Branches 5566 5566
=======================================
Hits 52313 52313
Misses 4189 4189
Partials 1435 1435 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
superlopuh
approved these changes
Nov 20, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
Changes `parse_with_type` from a classmethod to a staticmethod allowing a stricter type constraint to be put on the input type and allowing the removal of a cast and pyright suppression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
parse_with_typefrom a classmethod to a staticmethod allowing a stricter type constraint to be put on the input type and allowing the removal of a cast and pyright suppression