core: make TypedAttribute printing generic #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
commented
Nov 20, 2024
| if isinstance(attribute, TypedAttribute): | ||
| attribute.print_without_type(self) | ||
| self.print_string(" : ") | ||
| self.print_attribute(attribute.parameters[attribute.get_type_index()]) |
There was a problem hiding this comment.
This is the line which needs get_type_index to be a classmethod
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3490 +/- ##
=======================================
Coverage 90.31% 90.31%
=======================================
Files 462 462
Lines 58039 58040 +1
Branches 5562 5563 +1
=======================================
+ Hits 52417 52419 +2
Misses 4188 4188
+ Partials 1434 1433 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
superlopuh
reviewed
Nov 20, 2024
superlopuh
approved these changes
Nov 20, 2024
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
This currently doesn't really do anything because `IntegerAttr` is the only `TypedAttribute`. But after future PRs this will unify the way in which `TypedAttribute` is printed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently doesn't really do anything because
IntegerAttris the onlyTypedAttribute. But after future PRs this will unify the way in whichTypedAttributeis printed.There is a potential worry about circularity here if someone calls
print_attributeinprint_without_typebut I think this would have caused problems anyway