dialects: (bufferization) fix materialize_in_destination #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
force-pushed
the
alexarice/bufferize-fix
branch
from
a36698d to
c41a4cd
Compare
alexarice
changed the base branch from
main
to
alexarice/functional-type-directive
|
@francescodaghero does this fix the issue? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3495 +/- ##
=======================================
Coverage 90.39% 90.39%
=======================================
Files 467 467
Lines 58870 58870
Branches 5609 5609
=======================================
+ Hits 53216 53218 +2
+ Misses 4208 4207 -1
+ Partials 1446 1445 -1 ☔ View full report in Codecov by Sentry. |
alexarice
force-pushed
the
alexarice/bufferize-fix
branch
from
c41a4cd to
99993db
Compare
superlopuh
approved these changes
Dec 4, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
…#3495) Fixes xdslproject#3489 In order to make `materialize_in_destination` compatible with mlir, it needs to be able to take a memref type as the destination, and have an optional result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3489
In order to make
materialize_in_destinationcompatible with mlir, it needs to be able to take a memref type as the destination. However, in mlir there must be no result if the destination is a memref and so the result here must be optional. This causes a further problem in giving the assembly format which I am yet to solve.Next steps:
operandsassembly format directive (core: Add operands directive #3507)resultsassembly format directive (core: Add results directive #3518)functional-typeassembly format directive (I believe this will need some way to tell how many things a directive will print) (core: add functional-type directive #3517)bufferize.materialize_in_destination