Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects (arm): add return instruction (bx lr) #3521

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

emmau678
Copy link
Contributor

Add a return instruction which is equivalent to bx lr

@emmau678 emmau678 added the dialects Changes on the dialects label Nov 26, 2024
@emmau678 emmau678 self-assigned this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (158cfe1) to head (e9c0f75).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3521      +/-   ##
==========================================
+ Coverage   90.33%   90.35%   +0.02%     
==========================================
  Files         464      466       +2     
  Lines       58169    58481     +312     
  Branches     5559     5582      +23     
==========================================
+ Hits        52546    52841     +295     
- Misses       4192     4210      +18     
+ Partials     1431     1430       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@emmau678 emmau678 marked this pull request as ready for review November 27, 2024 16:18
@emmau678 emmau678 merged commit 6f203de into main Nov 27, 2024
15 checks passed
@emmau678 emmau678 deleted the emma/arm-ret-op branch November 27, 2024 16:19
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
Add a return instruction which is equivalent to ```bx lr```

---------

Co-authored-by: emmau678 <eu233@Emma-laptop>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants