dialects: (builtin) DenseIntOrFPElementsAttr: make data private and use getters instead #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se getters instead
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3535 +/- ##
=======================================
Coverage 90.35% 90.36%
=======================================
Files 466 466
Lines 58481 58515 +34
Branches 5582 5583 +1
=======================================
+ Hits 52841 52877 +36
+ Misses 4210 4208 -2
Partials 1430 1430 ☔ View full report in Codecov by Sentry. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
math-fehr
approved these changes
Nov 28, 2024
superlopuh
reviewed
Nov 28, 2024
superlopuh
reviewed
Nov 28, 2024
superlopuh
reviewed
Nov 28, 2024
Comment on lines
+48
to
+50
| and val.is_splat() | ||
| ): | ||
| return val.data.data[0] | ||
| return val.get_attrs()[0] |
superlopuh
reviewed
Nov 28, 2024
superlopuh
approved these changes
Nov 29, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
…se getters instead (xdslproject#3535) To prepare for the change of internal data representation, this PR makes the actual data of the attribute a private attribute. Everthing is accessed with the getters `get_attrs` (IntegerAttr, ...) and `get_values` (int, float). The check whether the dense is set by a scalar is pretty common, so i included an additional helper function for that as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for the change of internal data representation, this PR makes the actual data of the attribute a private attribute. Everthing is accessed with the getters
get_attrs(IntegerAttr, ...) andget_values(int, float).The check whether the dense is set by a scalar is pretty common, so i included an additional helper function for that as well