Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (builtin) remove Index support in DenseArrayBase #3541

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

superlopuh
Copy link
Member

This was never supported by MLIR

@superlopuh superlopuh added the dialects Changes on the dialects label Nov 29, 2024
@superlopuh superlopuh self-assigned this Nov 29, 2024
@superlopuh superlopuh changed the title dialects: (builtin) remove deprecated DenseArrayBase.create_dense_int_or_index dialects: (builtin) remove Index support in DenseArrayBase Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base (d365db8) to head (40b0ab5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3541      +/-   ##
==========================================
- Coverage   90.36%   90.36%   -0.01%     
==========================================
  Files         466      466              
  Lines       58508    58509       +1     
  Branches     5582     5583       +1     
==========================================
  Hits        52871    52871              
+ Misses       4209     4208       -1     
- Partials     1428     1430       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh merged commit ee28a09 into main Nov 29, 2024
15 checks passed
@superlopuh superlopuh deleted the sasha/builtin/remove-dense-array-index branch November 29, 2024 09:00
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants