dialects: (builtin) verify that the elements of dense satisfy type #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3544 +/- ##
=======================================
Coverage 90.36% 90.37%
=======================================
Files 466 466
Lines 58522 58545 +23
Branches 5583 5585 +2
=======================================
+ Hits 52886 52909 +23
Misses 4207 4207
Partials 1429 1429 ☔ View full report in Codecov by Sentry. |
jorendumoulin
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Nice!
When converting to bytes type, we'll probably have to adjust the ranges of the Signedness values to the ones of struct.pack, or add some preprocessing logic.
>>> pack('@b', 128)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
struct.error: 'b' format requires -128 <= number <= 127
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
…dslproject#3544) Instead of scary doc string, warn the user at the point of DenseArrayBase parsing/creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of scary doc string, warn the user at the point of DenseArrayBase parsing/creation.