Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transformations (csl): Add prefetch lowering #3584

Merged
merged 9 commits into from
Dec 6, 2024
Merged

transformations (csl): Add prefetch lowering #3584

merged 9 commits into from
Dec 6, 2024

Conversation

emmau678
Copy link
Contributor

@emmau678 emmau678 commented Dec 6, 2024

Add a prefetch lowering by rewriting csl_stencil.prefetch into a communicate-only csl_stencil.apply

@emmau678 emmau678 added hackathon To be tackled at the hackathon transformations Changes or adds a transformatio labels Dec 6, 2024
@emmau678 emmau678 requested a review from n-io December 6, 2024 15:17
@emmau678 emmau678 self-assigned this Dec 6, 2024
@alexarice
Copy link
Collaborator

What's with the hackathon tag? Did I miss some news?

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (8e58c88) to head (16c51c6).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3584      +/-   ##
==========================================
- Coverage   90.41%   90.38%   -0.04%     
==========================================
  Files         469      469              
  Lines       58945    59086     +141     
  Branches     5611     5617       +6     
==========================================
+ Hits        53297    53405     +108     
- Misses       4208     4235      +27     
- Partials     1440     1446       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io marked this pull request as ready for review December 6, 2024 16:41
@n-io n-io requested a review from compor December 6, 2024 16:50
@n-io n-io mentioned this pull request Dec 6, 2024
Open
50 tasks
@emmau678 emmau678 merged commit 3874827 into main Dec 6, 2024
15 checks passed
@emmau678 emmau678 deleted the emma/translate-prefetch branch December 6, 2024 16:56
n-io
n-io reviewed Dec 10, 2024
View reviewed changes
tests/filecheck/transforms/convert-stencil-to-csl-stencil.mlir
@@ -3,217 +3,6 @@
builtin.module {
// CHECK-NEXT: builtin.module {

func.func @gauss_seidel(%a : !stencil.field<[-1,1023]x[-1,511]xtensor<512xf32>>, %b : !stencil.field<[-1,1023]x[-1,511]xtensor<512xf32>>) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dk949 @emmau678 we removed a large chunk of the filecheck for testing purposes, but then accidentally committed and pushed. Will raise a PR to put this back in.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @superlopuh

@n-io n-io mentioned this pull request Dec 10, 2024
Merged
n-io added a commit that referenced this pull request Dec 10, 2024
@n-io
minor: (convert-stencil-to-csl-stencil) Adding accidentally removed f…
e13d337 
…ilecheck back in (#3616)

Revert part of #3584 that removed parts of a filecheck by accident.

Co-authored-by: n-io <n-io@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n-io n-io n-io approved these changes

@compor compor Awaiting requested review from compor

Assignees

@emmau678 emmau678

Labels
hackathon To be tackled at the hackathon transformations Changes or adds a transformatio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emmau678 @alexarice @compor @n-io