Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: set maxIndividualTestTime in lit cfg #3590

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

superlopuh
Copy link
Member

@superlopuh superlopuh added the CI Continuous Integration label Dec 7, 2024
@superlopuh superlopuh requested a review from math-fehr December 7, 2024 15:59
@superlopuh superlopuh self-assigned this Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (fe9f649) to head (2fda918).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3590   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files         469      469           
  Lines       59077    59075    -2     
  Branches     5615     5615           
=======================================
  Hits        53397    53397           
+ Misses       4233     4232    -1     
+ Partials     1447     1446    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh merged commit 4bbeecb into main Dec 7, 2024
15 checks passed
@superlopuh superlopuh deleted the sasha/misc/consistent-timeout branch December 7, 2024 16:06
@compor
Copy link
Collaborator

compor commented Dec 9, 2024

@superlopuh what was the need for this? my issue is that using that default locally causes some tests to timeout, leading to the inability to generate a coverage report.

The quickest workaround would be to pass the timeout in the Makefile from the environment and use lit's --timeout option.
Would it be OK if I open a PR with this?

@superlopuh
Copy link
Member Author

If we need more time then let's add more time, we do want a timeout though because some things have taken infinity time in the past.

@superlopuh
Copy link
Member Author

BTW I think we can safely remove the timeout in the makefile, I forgot to do that in this PR

@compor
Copy link
Collaborator

compor commented Dec 9, 2024

yeah, I know, it's inconsistently used in the current rules. The cmd line option overrides the lit configuration, so I'm happy to use it as such.

I'll fix it in a wee PR.

compor added a commit that referenced this pull request Dec 9, 2024
…uring `make` invocation (#3608)

This PR:

- Groups `lit` options as a Makefile variable that can be overridden
during `make` invocation,
  e.g., `make filecheck LIT_OPTIONS="-v --order=smart --timeout=30`
- The default timeout value is 20secs and it is currently provided in
`lit.cfg` since #3590
- the `-vv` option is deprecated, `-v` does what we want.

Based on the discussion
[here](#3590 (comment)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants