-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: set maxIndividualTestTime in lit cfg #3590
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3590 +/- ##
=======================================
Coverage 90.38% 90.38%
=======================================
Files 469 469
Lines 59077 59075 -2
Branches 5615 5615
=======================================
Hits 53397 53397
+ Misses 4233 4232 -1
+ Partials 1447 1446 -1 ☔ View full report in Codecov by Sentry. |
@superlopuh what was the need for this? my issue is that using that default locally causes some tests to timeout, leading to the inability to generate a coverage report. The quickest workaround would be to pass the timeout in the Makefile from the environment and use |
If we need more time then let's add more time, we do want a timeout though because some things have taken infinity time in the past. |
BTW I think we can safely remove the timeout in the makefile, I forgot to do that in this PR |
yeah, I know, it's inconsistently used in the current rules. The cmd line option overrides the lit configuration, so I'm happy to use it as such. I'll fix it in a wee PR. |
…uring `make` invocation (#3608) This PR: - Groups `lit` options as a Makefile variable that can be overridden during `make` invocation, e.g., `make filecheck LIT_OPTIONS="-v --order=smart --timeout=30` - The default timeout value is 20secs and it is currently provided in `lit.cfg` since #3590 - the `-vv` option is deprecated, `-v` does what we want. Based on the discussion [here](#3590 (comment)).
I copied the approach in https://github.com/llvm/llvm-project/blob/69227a11fe1d00b2fc6f93b2a985abbe888d0876/bolt/test/lit.cfg.py#L55