core: move logic specific to the MLIR grammar from lexer to mlir_lexer #3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3591 +/- ##
==========================================
- Coverage 90.38% 90.38% -0.01%
==========================================
Files 469 470 +1
Lines 59075 59095 +20
Branches 5615 5615
==========================================
+ Hits 53397 53415 +18
- Misses 4232 4233 +1
- Partials 1446 1447 +1 ☔ View full report in Codecov by Sentry. |
compor
approved these changes
Dec 9, 2024
math-fehr
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples the base lexing infrastructure from MLIR's syntax allowing us to to reuse it for other grammars, such as Toy, WASM, Stim, and other downstream projects.