Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: use generic lexer infrastructure in Toy parser #3593

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

superlopuh
Copy link
Member

Just to make sure that it really is generic, here's the port of Toy's lexing to the new structure. Up next: generic base parser infrastructure.

Note stacked PR.

@superlopuh superlopuh added the documentation Improvements or additions to documentation label Dec 8, 2024
@superlopuh superlopuh self-assigned this Dec 8, 2024
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.40%. Comparing base (09f495a) to head (328f062).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3593   +/-   ##
=======================================
  Coverage   90.39%   90.40%           
=======================================
  Files         470      470           
  Lines       59123    59126    +3     
  Branches     5616     5610    -6     
=======================================
+ Hits        53443    53451    +8     
+ Misses       4233     4232    -1     
+ Partials     1447     1443    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@compor compor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's great

@superlopuh superlopuh force-pushed the sasha/parser/mlir-lexer-rename branch from 2ef383b to 016611c Compare December 9, 2024 16:29
Base automatically changed from sasha/parser/mlir-lexer-rename to main December 9, 2024 17:36
@superlopuh superlopuh merged commit cbcf7f4 into main Dec 9, 2024
15 checks passed
@superlopuh superlopuh deleted the sasha/parser/toy-lexer branch December 9, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants