core: split out non-MLIR-specific parser functionality to GenericParser #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3595 +/- ##
=======================================
Coverage 90.40% 90.40%
=======================================
Files 470 471 +1
Lines 59127 59137 +10
Branches 5610 5610
=======================================
+ Hits 53452 53464 +12
+ Misses 4232 4231 -1
+ Partials 1443 1442 -1 ☔ View full report in Codecov by Sentry. |
compor
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
I saw this part of the PR stack this morning, but I forgot to finalize the review.
It might be useful to "track the PR stack" as @math-fehr did in #3538 :)
superlopuh
force-pushed
the
sasha/parser/circular-imports
branch
from
f18858c to
ec4f78c
Compare
superlopuh
force-pushed
the
sasha/parser/generic-parser
branch
from
189b337 to
b34ff53
Compare
|
Mathieu used a tool for that, which seems to do a part of the work for you, I'm happy to try it out when I next feel like building a tower :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets us use the generic Lexer infrastructure for other Parsers.