transformations: (apply-individual-rewrite) give more context in error message [NFC] #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
approved these changes
Dec 9, 2024
alexarice
reviewed
Dec 9, 2024
| @@ -124,4 +124,6 @@ def apply(self, ctx: MLContext, op: ModuleOp) -> None: | |||
|
|
|||
| pattern.match_and_rewrite(matched_operation, rewriter) | |||
| if not rewriter.has_done_action: | |||
| raise ValueError("Invalid rewrite at current location.") | |||
| raise ValueError( | |||
| f"Invalid rewrite ({pattern}) for operation ({matched_operation}) at location {self.matched_operation_index}." | |||
There was a problem hiding this comment.
I was too quick to approve, this should probably use self.pattern_name
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3602 +/- ##
=======================================
Coverage 90.38% 90.38%
=======================================
Files 469 469
Lines 59071 59071
Branches 5615 5615
=======================================
Hits 53393 53393
Misses 4232 4232
Partials 1446 1446 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps debug