Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (builtin) add support for f16 packing and unpacking #3605

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jorendumoulin
Copy link
Collaborator

The "<e" comes with the following warning:

The IEEE 754 binary16 “half precision” type was introduced in the 2008 revision of the IEEE 754 standard. It has a sign bit, a 5-bit exponent and 11-bit precision (with 10 bits explicitly stored), and can represent numbers between approximately 6.1e-05 and 6.5e+04 at full precision. This type is not widely supported by C compilers: on a typical machine, an unsigned short can be used for storage, but not for math operations. See the Wikipedia page on the half-precision floating-point format for more information.

As we only use it for storage, this should be fine though imo

@jorendumoulin jorendumoulin self-assigned this Dec 9, 2024
@jorendumoulin jorendumoulin added the dialects Changes on the dialects label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.39%. Comparing base (b88d7ad) to head (9398818).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3605   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files         469      469           
  Lines       59098    59102    +4     
  Branches     5616     5616           
=======================================
+ Hits        53419    53423    +4     
  Misses       4232     4232           
  Partials     1447     1447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jorendumoulin jorendumoulin merged commit 691f784 into main Dec 9, 2024
15 checks passed
@jorendumoulin jorendumoulin deleted the joren/packable-f16 branch December 9, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants