Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects (riscv_func): Use assembly format for riscv_func.call operation #3622

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

compor
Copy link
Collaborator

@compor compor commented Dec 11, 2024

This PR:

  • uses the declarative assembly format for riscv_func.call made possible by functional-type core: add functional-type directive #3517
  • removes unused utility methods for generic printing/parsing of the above since there are no users for them as a result of the above

Also discussed in #3618

@compor compor added the dialects Changes on the dialects label Dec 11, 2024
@compor compor self-assigned this Dec 11, 2024
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (e719c7f) to head (ad09a9d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3622      +/-   ##
==========================================
- Coverage   90.48%   90.47%   -0.01%     
==========================================
  Files         472      472              
  Lines       59276    59248      -28     
  Branches     5637     5636       -1     
==========================================
- Hits        53633    53606      -27     
  Misses       4205     4205              
+ Partials     1438     1437       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@compor compor merged commit 768eb79 into main Dec 11, 2024
15 checks passed
@compor compor deleted the christos/dialect/rv-func/use-assembly-fmt branch December 11, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants