Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (builtin) apply normalization on ints, not IntAttrs #3625

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

jorendumoulin
Copy link
Collaborator

the current flow of creating dense attrs is the following:
parse -> int -> IntAttr -> normalize -> IntAttr -> int -> bytes

this PR changes the normalization to work on ints to get the following:
parse -> int -> normalize -> int -> bytes

which simplifies things somewhat and should improve performance significantly for larger arrays

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (768eb79) to head (9ee44f7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3625      +/-   ##
==========================================
- Coverage   90.47%   90.47%   -0.01%     
==========================================
  Files         472      472              
  Lines       59248    59247       -1     
  Branches     5636     5636              
==========================================
- Hits        53606    53603       -3     
- Misses       4205     4206       +1     
- Partials     1437     1438       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh
Copy link
Member

Can you please assign yourself in PRs and add the appropriate label?

@jorendumoulin jorendumoulin self-assigned this Dec 11, 2024
@jorendumoulin jorendumoulin added the dialects Changes on the dialects label Dec 11, 2024
@jorendumoulin
Copy link
Collaborator Author

yes! sorry

@jorendumoulin jorendumoulin merged commit f8494f6 into main Dec 11, 2024
15 checks passed
@jorendumoulin jorendumoulin deleted the joren/normalize-ints branch December 11, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants