Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects (llvm): Add dense array constraint for the position attribute of llvm.extractvalue and llvm.insertvalue operations #3643

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

compor
Copy link
Collaborator

@compor compor commented Dec 16, 2024

This PR:

  • Adds a dense array constraint for the position attribute of llvm.extractvalue and llvm.insertvalue operations, restricting to i64 as in MLIR.
  • Filecheck tests of the above

Resolves #3155

@compor compor added the dialects Changes on the dialects label Dec 16, 2024
@compor compor self-assigned this Dec 16, 2024
xdsl/dialects/builtin.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (7c4cb63) to head (d79f192).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3643      +/-   ##
==========================================
+ Coverage   90.73%   90.75%   +0.01%     
==========================================
  Files         465      467       +2     
  Lines       58780    58907     +127     
  Branches     5635     5639       +4     
==========================================
+ Hits        53336    53463     +127     
- Misses       4000     4001       +1     
+ Partials     1444     1443       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@compor compor merged commit 3725f40 into main Dec 16, 2024
16 checks passed
@compor compor deleted the christos/dialects/llvm/fix-extract-insert-value-op branch December 16, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
2 participants