Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects (func): Add SymbolUserOpInterface implementation for func.call operation #3652

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

compor
Copy link
Collaborator

@compor compor commented Dec 18, 2024

This PR:

  • Adds support for the SymbolUserOpInterface interface and implements it for func.call
  • Adds tests (pytest and filecheck) of the above

Resolves #3497

@compor compor added dialects Changes on the dialects core xDSL core (ir, textual format, ...) labels Dec 18, 2024
@compor compor self-assigned this Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.73%. Comparing base (b8611e0) to head (d9a49db).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3652   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files         467      467           
  Lines       58965    59002   +37     
  Branches     5639     5647    +8     
=======================================
+ Hits        53499    53536   +37     
  Misses       4020     4020           
  Partials     1446     1446           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xdsl/dialects/func.py Outdated Show resolved Hide resolved
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@compor compor merged commit 4b15917 into main Dec 19, 2024
16 checks passed
@compor compor deleted the christos/dialects/func/symboluser-op-interface branch December 19, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...) dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dialects: (func) "func.call" does not verify function signature
2 participants