Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive: add mlir-opt pass to condensed list #3658

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

dshaaban01
Copy link
Collaborator

@dshaaban01 dshaaban01 commented Dec 19, 2024

This actually adds the mlir-opt pass to the condensed list (see commented line 65), this previous implementation did not do that - it did nothing, in fact.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (48642de) to head (b80c362).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3658      +/-   ##
==========================================
- Coverage   90.75%   90.75%   -0.01%     
==========================================
  Files         467      467              
  Lines       59141    59139       -2     
  Branches     5661     5661              
==========================================
- Hits        53671    53669       -2     
  Misses       4022     4022              
  Partials     1448     1448              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh
Copy link
Member

Can you please change the title to reflect the error, instead of describing it as small?

@superlopuh
Copy link
Member

Also, could you please set the label?

@dshaaban01 dshaaban01 changed the title interactive: fix small error interactive: add mlir-opt pass to condensed list Dec 20, 2024
@dshaaban01 dshaaban01 added the interactive xdsl-gui things label Dec 20, 2024
@dshaaban01
Copy link
Collaborator Author

Done.

@dshaaban01 dshaaban01 merged commit 753ae32 into main Dec 20, 2024
16 checks passed
@dshaaban01 dshaaban01 deleted the dalia/xdsl-fix branch December 20, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interactive xdsl-gui things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants