Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation: add mechanism for symlinking mlir-opt when creating venv #3660

Merged
merged 5 commits into from
Dec 24, 2024
Merged

installation: add mechanism for symlinking mlir-opt when creating venv #3660

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
61b0df1
installation: add mechanism for symlinking mlir-opt when creating venv
superlopuh Dec 20, 2024
0a083e1
remove .env things for now
superlopuh Dec 21, 2024
c70a513
use MLIR_OPT_PATH
superlopuh Dec 24, 2024
cb1efa0
add back readme
superlopuh Dec 24, 2024
a56a947
Merge branch 'main' into sasha/misc/env
superlopuh Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ uv-installed:
.PHONY: ${VENV_DIR}/
${VENV_DIR}/: uv-installed
XDSL_VERSION_OVERRIDE="0+dynamic" uv sync ${VENV_EXTRAS}
@if [ ! -z "$(XDSL_MLIR_BIN)" ]; then \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably rename this MLIR_OPT_PATH and point directly to mlir-opt instead?

ln -sf $(XDSL_MLIR_BIN)/mlir-opt ${VENV_DIR}/bin/mlir-opt; \
fi

# make sure `make venv` also works correctly
.PHONY: venv
Expand Down
Loading