core: Add attributes to func outputs #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3661 +/- ##
==========================================
+ Coverage 90.73% 91.29% +0.56%
==========================================
Files 467 466 -1
Lines 58965 58327 -638
Branches 5640 5638 -2
==========================================
- Hits 53500 53248 -252
+ Misses 4020 3629 -391
- Partials 1445 1450 +5 ☔ View full report in Codecov by Sentry. |
alexarice
reviewed
Dec 20, 2024
| // CHECK: func.func @output_attributes() -> (f32 {"a" = 0 : i32}, f32 {"b" = 0 : i32, "c" = 1 : i64}) { | ||
| // CHECK-NEXT: %r1, %r2 = "test.op"() : () -> (f32, f32) | ||
| // CHECK-NEXT: func.return %r1, %r2 : f32, f32 | ||
| // CHECK-NEXT: } |
There was a problem hiding this comment.
It would be nice to have a generic format filecheck and an mlir integration filecheck for this.
There was a problem hiding this comment.
Makes sense. Done.
superlopuh
reviewed
Dec 20, 2024
xdsl/dialects/riscv_func.py
Outdated
Comment on lines
177
to
181
| (name, input_types, return_types, region, extra_attrs, arg_attrs, _) = ( | ||
| parse_func_op_like( | ||
| parser, | ||
| reserved_attr_names=("sym_name", "function_type", "sym_visibility"), | ||
| ) |
There was a problem hiding this comment.
can you please raise NotImplementedError if there are any res_attrs here and in other places?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mlir supports attributes for output types. We need for cross compatibility with other mlir projects.