Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (scf/scf_for) Factor out print and parse methods for For-like operations #3662

Merged
merged 7 commits into from
Jan 7, 2025

Conversation

compor
Copy link
Collaborator

@compor compor commented Dec 20, 2024

This PR:

  • Factors out print and parse methods for For-like operations (currently scf.for, riscv_scf.for and riscv_scf.rof.

@compor compor added the dialects Changes on the dialects label Dec 20, 2024
@compor compor self-assigned this Dec 20, 2024
Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is potentially an interesting target for assembly format. I don't think we have any support for region arguments in assembly_format/pyrdl yet

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (977a09e) to head (c1bb8cc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3662      +/-   ##
==========================================
- Coverage   91.33%   91.32%   -0.01%     
==========================================
  Files         467      467              
  Lines       58548    58514      -34     
  Branches     5647     5652       +5     
==========================================
- Hits        53472    53436      -36     
  Misses       3626     3626              
- Partials     1450     1452       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@compor compor force-pushed the christos/dialects/abstract-for-print-parse branch from f49064a to 9af0f43 Compare January 7, 2025 10:27
@compor compor merged commit 57acf22 into main Jan 7, 2025
16 checks passed
@compor compor deleted the christos/dialects/abstract-for-print-parse branch January 7, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants