Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: (csl-stencil-bufferize) AccessOp to read to_tensor's underlying memref #3663

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Dec 20, 2024

csl_stencil.AccessOps can read directly from memrefs underlying any bufferization.to_tensor passed into them.

Currently, in the presence of several buffers (ie, stencil fields translated to memrefs at this stage), all but the main buffer will have intermediate bufferization.to_tensor ops, which creates problems in lowering. The AccessOps can instead work directly off of the underlying memrefs.

@n-io n-io added dialects Changes on the dialects minor For minor PRs, easy and quick to review, quickly mergeable labels Dec 20, 2024
@n-io n-io requested review from dk949 and emmau678 December 20, 2024 15:25
@n-io n-io self-assigned this Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (753ae32) to head (8e911b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3663   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files         466      466           
  Lines       58310    58311    +1     
  Branches     5634     5634           
=======================================
+ Hits        53232    53235    +3     
+ Misses       3629     3628    -1     
+ Partials     1449     1448    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@n-io n-io merged commit e5e9069 into main Dec 20, 2024
16 checks passed
@n-io n-io deleted the nicolai/csl-stencil-bufferize-prefetched-memrefs branch December 20, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants