dialects: (builtin) Parse @ module names

[mamanain]

It seems that modules in xdsl already support sym_name attribute but we don't parse @-starting names.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (fb41de5) to head (cfa53a6).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3664      +/-   ##
==========================================
- Coverage   91.29%   91.29%   -0.01%     
==========================================
  Files         466      466              
  Lines       58354    58357       +3     
  Branches     5639     5624      -15     
==========================================
+ Hits        53276    53278       +2     
  Misses       3629     3629              
- Partials     1449     1450       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[superlopuh]

This looks great, although this is a good opportunity to make the module name a property, and it'll simplify the format logic:

❯ echo "module @hello {}" | mlir-opt --mlir-print-op-generic
"builtin.module"() <{sym_name = "hello"}> ({
^bb0:
}) : () -> ()

[superlopuh]

Does this work?

`builtin.module` ($sym_name^)? attr-dict-with-keyword $bodyRegion

[mamanain]

Does this work?

`builtin.module` ($sym_name^)? attr-dict-with-keyword $bodyRegion

You mean does the combination of module name and attribute work? It does, added a test for it.

[math-fehr]

Looks good, I would just change a bit the init with my comment

[math-fehr]

Ad properties are not extensible, and would only contain the sym_name, I would just pass a StringAttr | None instead, and create the properties dictionary in the init

[mamanain]

Makes sense. Done, thanks.

[superlopuh]

Suggested change

	if "sym_name" in self.properties and isinstance(
	self.properties["sym_name"], StringAttr
	):
	printer.print(f" @{self.properties['sym_name'].data}")
	if self.sym_name is not None:
	printer.print(f" @{self.sym_name.data}")

[superlopuh]

Thank you!

[superlopuh]

I meant to use the assembly_format, but there's currently a circular dependency of the assembly format parser on builtin dialect so let's not go there.