Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix attributes to func outputs #3675

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

mamanain
Copy link
Collaborator

There is a bug when we want to print a single output parameter with attributes - it still needs to be enclosed in braces.

@mamanain mamanain added the core xDSL core (ir, textual format, ...) label Dec 24, 2024
@mamanain mamanain requested a review from superlopuh December 24, 2024 16:57
@mamanain mamanain self-assigned this Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (6411225) to head (d3ab8fa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3675   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files         466      466           
  Lines       58357    58357           
  Branches     5624     5624           
=======================================
  Hits        53278    53278           
  Misses       3629     3629           
  Partials     1450     1450           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mamanain mamanain merged commit 9094df5 into xdslproject:main Dec 24, 2024
16 checks passed
@mamanain mamanain deleted the manainen/output-attributes-fix branch December 24, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants