Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: split bottom_up into f32 and f64 kernels #3676

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

superlopuh
Copy link
Member

There's still a bit of work to do on the f32 front, this PR just splits the test file, and removes erroneous f32 mentions from the f64 kernels.

@superlopuh superlopuh added the testing PRs that modify tests label Dec 25, 2024
@superlopuh superlopuh self-assigned this Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (6f59234) to head (9870569).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3676   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files         466      466           
  Lines       58357    58357           
  Branches     5624     5624           
=======================================
  Hits        53278    53278           
  Misses       3629     3629           
  Partials     1450     1450           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mamanain mamanain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@superlopuh superlopuh merged commit 9e1f976 into main Dec 25, 2024
16 checks passed
@superlopuh superlopuh deleted the sasha/snitch-tensor/bottom-up-split branch December 25, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing PRs that modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants