Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpreter: support a tuple of listeners in Interpreter #3695

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

superlopuh
Copy link
Member

CombinedListener or CombinedListeners?

@superlopuh superlopuh added the interpreter xDSL Interpreter label Jan 3, 2025
@superlopuh superlopuh self-assigned this Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (f06d74e) to head (97d4e61).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3695      +/-   ##
==========================================
+ Coverage   91.30%   91.31%   +0.01%     
==========================================
  Files         466      467       +1     
  Lines       58375    58507     +132     
  Branches     5626     5642      +16     
==========================================
+ Hits        53297    53425     +128     
- Misses       3630     3632       +2     
- Partials     1448     1450       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not be cleaner to let Interpreter take a tuple of listeners?

@alexarice
Copy link
Collaborator

CombinedListener or CombinedListeners?

CombinedListener

@superlopuh
Copy link
Member Author

I'm not sure about the tuple thing, I'll give it a quick go locally now and see how I feel.

@superlopuh
Copy link
Member Author

I like it

Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this (with a change of title)

@superlopuh superlopuh changed the title interpreter: add functionality to combine Interpreter.Listeners interpreter: support a tuple of listeners in Interpreter Jan 6, 2025
@superlopuh superlopuh merged commit 2ce4059 into main Jan 6, 2025
16 checks passed
@superlopuh superlopuh deleted the sasha/autotuner/combined-listener branch January 6, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter xDSL Interpreter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants