-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interpreter: support a tuple of listeners in Interpreter #3695
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3695 +/- ##
==========================================
+ Coverage 91.30% 91.31% +0.01%
==========================================
Files 466 467 +1
Lines 58375 58507 +132
Branches 5626 5642 +16
==========================================
+ Hits 53297 53425 +128
- Misses 3630 3632 +2
- Partials 1448 1450 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not be cleaner to let Interpreter
take a tuple of listeners?
CombinedListener |
I'm not sure about the tuple thing, I'll give it a quick go locally now and see how I feel. |
I like it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this (with a change of title)
Interpreter.Listener
s
CombinedListener or CombinedListeners?