Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add __init__.py file to wgpu backend folder #3731

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

superlopuh
Copy link
Member

A downstream client of xDSL currently can't import it.

@superlopuh superlopuh added bug Something isn't working minor For minor PRs, easy and quick to review, quickly mergeable misc Miscellaneous labels Jan 9, 2025
@superlopuh superlopuh self-assigned this Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (0d39a26) to head (016b922).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3731      +/-   ##
==========================================
- Coverage   91.28%   91.27%   -0.01%     
==========================================
  Files         468      467       -1     
  Lines       58601    58579      -22     
  Branches     5656     5656              
==========================================
- Hits        53492    53470      -22     
  Misses       3659     3659              
  Partials     1450     1450              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is checking for these files precommitable/ci-able?

@superlopuh
Copy link
Member Author

I don't know, I wonder if there's a setting we can disable somewhere to only allow imports from Python packages, it's not the first time this happens...

@superlopuh superlopuh merged commit 10508af into main Jan 10, 2025
16 checks passed
@superlopuh superlopuh deleted the sasha/misc/wgsl-printer-init branch January 10, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor For minor PRs, easy and quick to review, quickly mergeable misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants