Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects (arm): add LabelAttr #3745

Merged
merged 5 commits into from
Jan 13, 2025
Merged

dialects (arm): add LabelAttr #3745

merged 5 commits into from
Jan 13, 2025

Conversation

emmau678
Copy link
Contributor

@emmau678 emmau678 commented Jan 13, 2025

Add LabelAttr to ARM dialect.

@emmau678 emmau678 added the dialects Changes on the dialects label Jan 13, 2025
@emmau678 emmau678 requested a review from superlopuh January 13, 2025 11:02
@emmau678 emmau678 self-assigned this Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (62e10cb) to head (b2a4378).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3745      +/-   ##
==========================================
- Coverage   91.30%   91.29%   -0.01%     
==========================================
  Files         468      469       +1     
  Lines       58636    58584      -52     
  Branches     5656     5651       -5     
==========================================
- Hits        53535    53485      -50     
- Misses       3650     3651       +1     
+ Partials     1451     1448       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@compor
Copy link
Collaborator

compor commented Jan 13, 2025

Maybe update the PR title and change to non-draft when ready? This is only going to have the attribute right?

@compor compor self-requested a review January 13, 2025 11:57
@emmau678 emmau678 changed the title dialects (arm): add LabelOp and LabelAttr dialects (arm): add LabelAttr Jan 13, 2025
@emmau678 emmau678 marked this pull request as ready for review January 13, 2025 13:33
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@emmau678 emmau678 merged commit 64f809b into main Jan 13, 2025
16 checks passed
@emmau678 emmau678 deleted the emma/arm_label_op_attr branch January 13, 2025 15:19
emmau678 added a commit that referenced this pull request Jan 13, 2025
superlopuh pushed a commit that referenced this pull request Jan 13, 2025
This reverts commit 64f809b. (Removes
LabelAttr)
emmau678 added a commit that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants