Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: update ImplicitBuilder doc comment #3782

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

superlopuh
Copy link
Member

fixes #3779

@superlopuh superlopuh added the documentation Improvements or additions to documentation label Jan 23, 2025
@superlopuh superlopuh self-assigned this Jan 23, 2025
Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that you can still pass a builder into ImplicitBuilder

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (9cdc462) to head (a0cea1c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3782   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         461      461           
  Lines       57490    57490           
  Branches     5543     5543           
=======================================
  Hits        52465    52465           
  Misses       3603     3603           
  Partials     1422     1422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh merged commit cafe3c5 into main Jan 23, 2025
16 checks passed
@superlopuh superlopuh deleted the sasha/documentation/builder-init branch January 23, 2025 11:51
oluwatimilehin pushed a commit to oluwatimilehin/xdsl that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation on implicit builder is out of date?
2 participants