dialects: (builtin) print hex str for DenseIntOrFPElementsAttrs with > 100 elements #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3846 +/- ##
=======================================
Coverage 91.26% 91.27%
=======================================
Files 461 461
Lines 57656 57656
Branches 5570 5571 +1
=======================================
+ Hits 52619 52623 +4
+ Misses 3612 3609 -3
+ Partials 1425 1424 -1 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Feb 5, 2025
oluwatimilehin
pushed a commit
to oluwatimilehin/xdsl
that referenced
this pull request
Feb 13, 2025
…> 100 elements (xdslproject#3846) mimicking mlir behaviour This, along with xdslproject#3845 should allow for very fast printing/parsing of large dense attrs, allowing for low-overhead calling of intermediate mlir-opt passes in our pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mimicking mlir behaviour
This, along with #3845 should allow for very fast printing/parsing of large dense attrs, allowing for low-overhead calling of intermediate mlir-opt passes in our pipeline.