Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: flatten assembly format class hierarchy #3893

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

alexarice
Copy link
Collaborator

Removes a few of the extra classes from the assembly format directives, instead replacing them with methods on the Directive class. This should make it simpler to implement custom directives in the future

@alexarice alexarice self-assigned this Feb 12, 2025
@alexarice alexarice added the core xDSL core (ir, textual format, ...) label Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.26%. Comparing base (9accdb1) to head (86c281c).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3893   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         466      466           
  Lines       57949    57961   +12     
  Branches     5575     5567    -8     
=======================================
+ Hits        52886    52898   +12     
- Misses       3635     3639    +4     
+ Partials     1428     1424    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexarice alexarice merged commit b12e743 into main Feb 13, 2025
16 checks passed
@alexarice alexarice deleted the alexarice/assembly-format-flatten branch February 13, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants