core: replace MLContext with Context #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
alexarice,
math-fehr,
PapyChacal and
webmiche
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3907 +/- ##
==========================================
- Coverage 91.28% 91.27% -0.01%
==========================================
Files 466 466
Lines 57985 57990 +5
Branches 5566 5566
==========================================
+ Hits 52929 52931 +2
- Misses 3629 3631 +2
- Partials 1427 1428 +1 ☔ View full report in Codecov by Sentry. |
alexarice
reviewed
Feb 14, 2025
| @@ -232,5 +232,7 @@ def get_optional_dialect(self, name: str) -> "Dialect | None": | |||
| return None | |||
|
|
|||
|
|
|||
| @deprecated("Please use Context instead") | |||
| class MLContext(Context): ... | |||
| class MLContext(Context): | |||
There was a problem hiding this comment.
What's wrong with @deprecated?
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
compor
approved these changes
Feb 14, 2025
compor
reviewed
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a single find and replace.
Fixes #249
Keeps MLContext as a deprecated subclass of Context for clients.