documentation: Fix nits on the first marimo notebook #3933
Conversation
compor
changed the title
| _first_info_text = exercise_text( | ||
| first_text_area.value, | ||
| "first", | ||
| ((1, 2), (3, 4)), | ||
| ("first(1, 2) = ", "first(3, 4) = "), | ||
| ) |
There was a problem hiding this comment.
Our ruff formatting excludes notebooks, so it's my local settings I assume.
There was a problem hiding this comment.
Are you editing the raw python locally or using marimo edit?
There was a problem hiding this comment.
Raw python locally, do you want me to run with the editor? I'll see if it can reformat these.
There was a problem hiding this comment.
Yeah it would be good to run it in the editor, before merging because they have their own formatter that will likely conflict with your changes.
There was a problem hiding this comment.
Yeah, there is no "format all cells", I have to go over each cell and do a ctrl-b
There was a problem hiding this comment.
"Run all cells" seems to do it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3933 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 467 467
Lines 58068 58068
Branches 5581 5581
=======================================
Hits 53021 53021
Misses 3616 3616
Partials 1431 1431 ☔ View full report in Codecov by Sentry. |
|
|
||
| A module is a unit of code which holds a single region. |
There was a problem hiding this comment.
Regions are not explained, so my main issue here is adding a definition earlier or omitting all together.
I'm inclined to do that later.
Minor nits and rewording of sentences.