documentation: fix arith cmpi example in MLIR IR notebook #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
math-fehr
approved these changes
Feb 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3942 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 467 467
Lines 58068 58068
Branches 5581 5581
=======================================
Hits 53021 53021
Misses 3616 3616
Partials 1431 1431 ☔ View full report in Codecov by Sentry. |
compor
reviewed
Feb 21, 2025
| @@ -165,19 +165,19 @@ def _(mo): | |||
| def _(): | |||
| less_than_text = """\ | |||
| func.func @less_than(%a: i32, %b: i32) -> i1 { | |||
| %slt = arith.cmpi slt, %lhs, %rhs : i1 | |||
| %slt = arith.cmpi slt, %lhs, %rhs : i32 | |||
There was a problem hiding this comment.
I have to admit, I always need to think about this for a minute to make sure it is the operands and not the bool-like return
There was a problem hiding this comment.
Yep same and it confused today's audience also
compor
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.