Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: remove xdsl-opt file #3954

Merged
merged 3 commits into from
Feb 24, 2025
Merged

misc: remove xdsl-opt file #3954

merged 3 commits into from
Feb 24, 2025

Conversation

superlopuh
Copy link
Member

I tested this locally by installing via a different path, seems like this is just unused at this point.

@superlopuh superlopuh added minor For minor PRs, easy and quick to review, quickly mergeable misc Miscellaneous labels Feb 24, 2025
@superlopuh superlopuh self-assigned this Feb 24, 2025
@compor
Copy link
Collaborator

compor commented Feb 24, 2025

I don't understand this?

@superlopuh
Copy link
Member Author

We have xdsl_opt_main.py, xdsl_opt.py, and xdsl-opt, feels like we need at most two

@compor
Copy link
Collaborator

compor commented Feb 24, 2025

We have xdsl_opt_main.py, xdsl_opt.py, and xdsl-opt, feels like we need at most two

Oh, I see now!

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (b3966ea) to head (21780c3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3954   +/-   ##
=======================================
  Coverage   91.31%   91.32%           
=======================================
  Files         467      467           
  Lines       58091    58141   +50     
  Branches     5581     5579    -2     
=======================================
+ Hits        53048    53098   +50     
- Misses       3616     3617    +1     
+ Partials     1427     1426    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh merged commit 94c47fe into main Feb 24, 2025
16 checks passed
@superlopuh superlopuh deleted the sasha/misc/xdsl-opt-file branch February 24, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants