Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: (riscv) use named unallocated registers instead of empty init #3972

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

superlopuh
Copy link
Member

Two related changes:

  • removes the default value of "" for the register name
  • replaces previous unallocated register init calls with no args with the dedicated UNALLOCATED constants

This reduces the users of the init API, which I'm slowly refactoring.

@superlopuh superlopuh self-assigned this Feb 26, 2025
@superlopuh superlopuh added the backend Compiler backend in xDSL label Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (539220f) to head (d5da219).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3972      +/-   ##
==========================================
- Coverage   90.15%   90.15%   -0.01%     
==========================================
  Files         459      459              
  Lines       58299    58290       -9     
  Branches     5690     5690              
==========================================
- Hits        52562    52553       -9     
  Misses       4346     4346              
  Partials     1391     1391              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about riscv but looks reasonable

@superlopuh superlopuh merged commit 124e131 into main Feb 26, 2025
16 checks passed
@superlopuh superlopuh deleted the sasha/registers/named-unallocated branch February 26, 2025 17:50
@compor
Copy link
Collaborator

compor commented Feb 27, 2025

I'm sorry, after a very brief look how does this fundamentally differ from the change of #3926?
It seems like we go back and forth with the unallocated? Is it too verbose or not after all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Compiler backend in xDSL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants