Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: (x86) use named register constants in ops file #3985

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

superlopuh
Copy link
Member

Avoids spurious register creation, and minimises the init API usage, which I propose changing in a different PR.

@superlopuh superlopuh added the backend Compiler backend in xDSL label Feb 28, 2025
@superlopuh superlopuh self-assigned this Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (592ae08) to head (05ee959).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3985   +/-   ##
=======================================
  Coverage   90.16%   90.16%           
=======================================
  Files         458      458           
  Lines       58287    58291    +4     
  Branches     5691     5691           
=======================================
+ Hits        52555    52559    +4     
  Misses       4340     4340           
  Partials     1392     1392           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@math-fehr math-fehr self-requested a review March 3, 2025 16:50
@superlopuh superlopuh merged commit 6ae4e5f into main Mar 3, 2025
16 checks passed
@superlopuh superlopuh deleted the sasha/backend/x86-named-regs branch March 3, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Compiler backend in xDSL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants