Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: use ConstraintContext for inference #4001

Merged
merged 2 commits into from
Mar 2, 2025

Conversation

superlopuh
Copy link
Member

In a way, both constraint verification and inference are a matching of a query with data, where we come up with assignments for the variables, and bail if a unique assignment is not found, so it makes sense to me to use the same data structure to represent variable assignment in both cases.

@superlopuh superlopuh added the core xDSL core (ir, textual format, ...) label Mar 2, 2025
@superlopuh superlopuh self-assigned this Mar 2, 2025
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (30248fd) to head (d64a5de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4001   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files         458      458           
  Lines       58312    58304    -8     
  Branches     5694     5694           
=======================================
- Hits        52580    52573    -7     
+ Misses       4340     4339    -1     
  Partials     1392     1392           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh merged commit 3d4d51d into main Mar 2, 2025
17 checks passed
@superlopuh superlopuh deleted the sasha/irdl/yeet-inference-context branch March 2, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants