Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: reuse field definition functions across op definitions #4016

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

superlopuh
Copy link
Member

We can reuse the function instances, so there's no need to redefine them for every operation definition.

Slight perf improvement for make filecheck, but it's annoyingly close to the margin off error, I look forward to seeing the perf results later. I also have a feeling that it should help pypy's tracing to have only one of each of these functions for all of xDSL, instead of one per op.

@superlopuh superlopuh added the core xDSL core (ir, textual format, ...) label Mar 4, 2025
@superlopuh superlopuh self-assigned this Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (c9493b7) to head (37d2ee5).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4016      +/-   ##
==========================================
- Coverage   90.19%   90.18%   -0.01%     
==========================================
  Files         458      458              
  Lines       58288    58314      +26     
  Branches     5687     5688       +1     
==========================================
+ Hits        52570    52593      +23     
- Misses       4328     4331       +3     
  Partials     1390     1390              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh merged commit 95e61cb into main Mar 4, 2025
17 checks passed
@superlopuh superlopuh deleted the sasha/pyrdl/move-out-getters branch March 4, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants