Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: add gitignore file for profile outputs #4018

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

EdmundGoodman
Copy link
Collaborator

@EdmundGoodman EdmundGoodman commented Mar 4, 2025

Add gitignore file for profile outputs in response to comment

@EdmundGoodman EdmundGoodman added the bench Benchmark related changes label Mar 4, 2025
@EdmundGoodman EdmundGoodman requested a review from superlopuh March 4, 2025 12:57
@EdmundGoodman EdmundGoodman self-assigned this Mar 4, 2025
@EdmundGoodman
Copy link
Collaborator Author

Hopefully an uncontroversial one to start with...

Will work out a good order to get more stuff in next. The seemingly obvious place to start is the bench_utils.py profiling stuff, but that is quite transient as I am adding stuff like bytecode visualisation, so perhaps some other benchmarks might be better?

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (458e3d0) to head (461abe1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4018   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files         458      458           
  Lines       58314    58314           
  Branches     5688     5688           
=======================================
  Hits        52593    52593           
  Misses       4331     4331           
  Partials     1390     1390           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@compor compor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please indicate the WIP/draft PR for people who are not following this closely, so that they know where this series of PRs originates from?

@EdmundGoodman
Copy link
Collaborator Author

Can you please indicate the WIP/draft PR for people who are not following this closely, so that they know where this series of PRs originates from?

What is the best way to do this? I've linked back to it in the first comment and there is a mention link in the thread -- is there a good way to put it in the title or similar?

@compor
Copy link
Collaborator

compor commented Mar 4, 2025

Can you please indicate the WIP/draft PR for people who are not following this closely, so that they know where this series of PRs originates from?

What is the best way to do this? I've linked back to it in the first comment and there is a mention link in the thread -- is there a good way to put it in the title or similar?

I think just clearly saying "Peeled off from #XYZW" in the initial comment is more than enough, and it links both PRs automatically.

@superlopuh superlopuh merged commit 02aae12 into main Mar 4, 2025
17 checks passed
@superlopuh superlopuh deleted the edmundgoodman/benchmarks/gitignore branch March 4, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bench Benchmark related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants