-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench: add gitignore file for profile outputs #4018
Conversation
Hopefully an uncontroversial one to start with... Will work out a good order to get more stuff in next. The seemingly obvious place to start is the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4018 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 458 458
Lines 58314 58314
Branches 5688 5688
=======================================
Hits 52593 52593
Misses 4331 4331
Partials 1390 1390 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please indicate the WIP/draft PR for people who are not following this closely, so that they know where this series of PRs originates from?
What is the best way to do this? I've linked back to it in the first comment and there is a mention link in the thread -- is there a good way to put it in the title or similar? |
I think just clearly saying "Peeled off from #XYZW" in the initial comment is more than enough, and it links both PRs automatically. |
Add gitignore file for profile outputs in response to comment