-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dialects #81
Update dialects #81
Conversation
0798386
to
8623ea0
Compare
I had some weird behaviour: After installing the rewritten dialects with |
43edfe9
to
bcd9595
Compare
bcd9595
to
794bf4c
Compare
Nice! Good from my side. Maybe @math-fehr has some further input. |
README.md
Outdated
xDSL can generate executables using MLIR as the backend. To use this functionality, make sure to install the [MLIR Python Bindings](https://mlir.llvm.org/docs/Bindings/Python/). Given an input file `input.xdsl`, that contains IR with only the mirrored dialects found in `src/xdsl/dialects` (arith, memref, func, cf, scf, and builtin), run: | ||
|
||
``` | ||
mlir-opt --convert-scf-to-cf --convert-cf-to-llvm --convert-func-to-llvm --convert-arith-to-llvm --convert-memref-to-llvm --reconcile-unrealized-casts *input.xdsl* | mlir-translate --mlir-to-llvmir > tmp.ll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we directly use an input.xdsl
file in MLIR?
Don't we need to use mlir_converter or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right, it should actually be passed through the mlir_converter aswell. I will think about how to properly integrate the tooling from the ChocoPy repo into xdsl. (I will probably add .mlir
as a target to xdsl_opt, similar to how we did in choco-opt)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my documentation comment, looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
There are some ugly things in the files touched by this PR, but changing this is not related to it.
This updates our mirrored dialects. In partiuclar, moves std to func, and moves the funcOp from builtin to func.